[
https://issues.apache.org/jira/browse/HDDS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619477#comment-16619477
]
Xiaoyu Yao edited comment on HDDS-488 at 9/18/18 7:40 PM:
----------------------------------------------------------
Thanks [~ajayydv] for working on this. THe patch looks good to me overall. Here
are a few comments:
KeyManagerImpl.java
Line 221-222: we should catch/rethrow OM exception for block allocation failure
due to chill mode similar to Line 159-170. Maybe add a private wrapper function
for reuse?
Line 290-295: I think this can be moved to 221-222.
was (Author: xyao):
Thanks [~ajayydv] for working on this. THe patch looks good to me overall. Here
are a few comments:
KeyManagerImpl.java
Line 221-222: we should catch/rethrow OM exception for block allocation failure
due to chill mode similar to Line 159-170. Maybe add a private wrapper function
for reuse?
Line 290-295: I think this can be moved to 221-222.
Line 304: It seems you want to allow commitKey as it is a OM/DN only operation.
KeyDeletingService.java
Line 128: we need to handle the chill mode exception here for the scm delete
call. Also please add a unit test in TestKeyDeletingService with chill mode
exception from scm mock.
> Handle chill mode exception from SCM in OzoneManager
> ----------------------------------------------------
>
> Key: HDDS-488
> URL: https://issues.apache.org/jira/browse/HDDS-488
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDDS-488.00.patch
>
>
> Following functions should propagate SCM chill mode exception back to the
> clients:
> allocateBlock
> openKey
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
