[ 
https://issues.apache.org/jira/browse/HDFS-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13083899#comment-13083899
 ] 

Eli Collins commented on HDFS-2186:
-----------------------------------

{noformat}
+1 overall.  

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 system test framework.  The patch passed system test framework compile.
{noformat}

> DN volume failures on startup are not counted
> ---------------------------------------------
>
>                 Key: HDFS-2186
>                 URL: https://issues.apache.org/jira/browse/HDFS-2186
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>             Fix For: 0.23.0
>
>         Attachments: hdfs-2186-1.patch
>
>
> Volume failures detected on startup are not currently counted/reported as 
> such. Eg if you have configured 4 volumes, 2 tolerated failures, and you 
> start a DN with two failed volumes it will come up and report (to the NN) no 
> failed volumes. The DN will still be able to tolerate 2 additional volume 
> failures (ie it's OK with no valid volumes remaining). The intent of the 
> volume failure toleration config value is that if more than this # of volumes 
> of the total set of configured volumes have failed the DN should shutdown, 
> therefore volume failures detected on startup should count against this 
> quota. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to