[ 
https://issues.apache.org/jira/browse/HDFS-13876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622167#comment-16622167
 ] 

Lokesh Jain commented on HDFS-13876:
------------------------------------

[~smeng] Thanks for working on this! The patch looks very good to me. I have a 
few minor comments.
 # We could use createSnapshotTestsPreconditions for testDisallowSnapshot in 
BaseTestHttpFSWith. We can use it for testAllowSnapshot as well by including an 
extra flag for doing an allowSnapshot.
 # Similarly we can use snapshotTestPreconditions in TestHttpFSServer.

> HttpFS: Implement ALLOWSNAPSHOT, DISALLOWSNAPSHOT
> -------------------------------------------------
>
>                 Key: HDFS-13876
>                 URL: https://issues.apache.org/jira/browse/HDFS-13876
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: httpfs
>    Affects Versions: 3.1.1, 3.0.3
>            Reporter: Siyao Meng
>            Assignee: Siyao Meng
>            Priority: Major
>         Attachments: HDFS-13876.001.patch
>
>
> Implement ALLOWSNAPSHOT, DISALLOWSNAPSHOT (from HDFS-9057) in HttpFS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to