[ 
https://issues.apache.org/jira/browse/HDDS-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622867#comment-16622867
 ] 

Anu Engineer edited comment on HDDS-370 at 9/20/18 11:30 PM:
-------------------------------------------------------------

[~ajayydv] I am +1; had a small sugggestion if you are going to post a new 
patch.

{{rpc isScmInChillMode(IsScmInChillModeRequestProto)}} are functions in the SCM 
client interface already. We can lose {{Scm}} from those names, also in the 
forceFunction call. Thx.

 

Don't post a new patch. I wrote this comment a while ago and just committed it. 
No need for a new patch.


was (Author: anu):
[~ajayydv] I am +1; had a small sugggestion if you are going to post a new 
patch. 

{{rpc isScmInChillMode(IsScmInChillModeRequestProto)}} are functions in the SCM 
client interface already. We can lose {{Scm}} from those names, also in the 
forceFunction call. Thx.

> Add and implement following functions in SCMClientProtocolServer
> ----------------------------------------------------------------
>
>                 Key: HDDS-370
>                 URL: https://issues.apache.org/jira/browse/HDDS-370
>             Project: Hadoop Distributed Data Store
>          Issue Type: New Feature
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>              Labels: alpha2
>         Attachments: HDDS-370.00.patch, HDDS-370.01.patch, HDDS-370.02.patch, 
> HDDS-370.03.patch, HDDS-370.04.patch, HDDS-370.05.patch
>
>
> Add and implement following functions in SCMClientProtocolServer
> # isScmInChillMode
> # forceScmExitChillMode



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to