[
https://issues.apache.org/jira/browse/HDFS-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084285#comment-13084285
]
Hadoop QA commented on HDFS-73:
-------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490270/HDFS-73_0.23_1.patch
against trunk revision 1156977.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery
org.apache.hadoop.hdfs.server.datanode.TestDataDirs
org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
org.apache.hadoop.hdfs.server.namenode.TestGetImageServlet
org.apache.hadoop.hdfs.server.namenode.TestINodeFile
org.apache.hadoop.hdfs.server.namenode.TestNNLeaseRecovery
org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings
org.apache.hadoop.hdfs.TestHDFSServerPorts
+1 contrib tests. The patch passed contrib unit tests.
-1 system test framework. The patch failed system test framework compile.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1100//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1100//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1100//console
This message is automatically generated.
> DFSOutputStream does not close all the sockets
> ----------------------------------------------
>
> Key: HDFS-73
> URL: https://issues.apache.org/jira/browse/HDFS-73
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Raghu Angadi
> Assignee: Uma Maheswara Rao G
> Priority: Blocker
> Fix For: 0.23.0
>
> Attachments: HADOOP-3071.patch, HDFS-73_0.23.patch,
> HDFS-73_0.23_1.patch
>
>
> When DFSOutputStream writes to multiple blocks, it closes only the socket
> opened for the last block. When it is done with writing to one block it
> should close the socket.
> I noticed this when I was fixing HADOOP-3067. After fixing HADOOP-3067, there
> were still a lot of sockets open (but not enough to fail the tests). These
> sockets were used to write to blocks.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
