[
https://issues.apache.org/jira/browse/HDFS-13930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624314#comment-16624314
]
Hadoop QA commented on HDFS-13930:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 2 new or modified test
files. {color} |
|| || || || {color:brown} HDFS-12943 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
51s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 18m
54s{color} | {color:green} HDFS-12943 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 8m
5s{color} | {color:green} HDFS-12943 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
39m 52s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 7m
56s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 8 line(s) that end in whitespace. Use git
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
11m 29s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
51s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
57s{color} | {color:green} hadoop-hdfs in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m
27s{color} | {color:green} hadoop-yarn in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
9s{color} | {color:green} hadoop-mapreduce-project in the patch passed. {color}
|
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
32s{color} | {color:green} hadoop-streaming in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
38s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 82m 58s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 |
| JIRA Issue | HDFS-13930 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12940855/HDFS-13930-HDFS-12943.000.patch
|
| Optional Tests | dupname asflicense mvnsite unit |
| uname | Linux b88e941ad161 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | HDFS-12943 / 77e106f |
| maven | version: Apache Maven 3.3.9 |
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/25125/artifact/out/whitespace-eol.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/25125/testReport/ |
| Max. process+thread count | 301 (vs. ulimit of 10000) |
| modules | C: hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn
hadoop-mapreduce-project hadoop-tools/hadoop-streaming U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/25125/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> Fix crlf line endings in HDFS-12943 branch
> ------------------------------------------
>
> Key: HDFS-13930
> URL: https://issues.apache.org/jira/browse/HDFS-13930
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Erik Krogen
> Assignee: Erik Krogen
> Priority: Major
> Attachments: HDFS-13930-HDFS-12943.000.patch
>
>
> One of the merge commits introduced the wrong line endings to some {{*.cmd}}
> files. Looks like it was commit {{1363eff69c3}} that broke it.
> The tree is:
> {code}
> * | 1363eff69c3 2018-09-17 Merge commit
> '9af96d4ed4b6f80d3ca53a2b003d2ef768650dd4' into HDFS-12943 [Konstantin V
> Shvachko <[email protected]>]
> |\ \
> | |/
> | * 9af96d4ed4b 2018-09-05 HADOOP-15707. Add IsActiveServlet to be used for
> Load Balancers. Contributed by Lukas Majercak. [Giovanni Matteo Fumarola
> <[email protected]>]
> * | 94d7f90e93b 2018-09-17 Merge commit
> 'e780556ae9229fe7a90817eb4e5449d7eed35dd8' into HDFS-12943 [Konstantin V
> Shvachko <[email protected]>]
> {code}
> So that merge commit should have only introduced a single new commit
> {{9af96d4ed4b}}. But:
> {code}
> ± git show --stat 9af96d4ed4b | cat
> commit 9af96d4ed4b6f80d3ca53a2b003d2ef768650dd4
> Author: Giovanni Matteo Fumarola <[email protected]>
> Date: Wed Sep 5 10:50:25 2018 -0700
> HADOOP-15707. Add IsActiveServlet to be used for Load Balancers.
> Contributed by Lukas Majercak.
> .../org/apache/hadoop/http/IsActiveServlet.java | 71 ++++++++++++++++
> .../apache/hadoop/http/TestIsActiveServlet.java | 95
> ++++++++++++++++++++++
> .../federation/router/IsRouterActiveServlet.java | 37 +++++++++
> .../server/federation/router/RouterHttpServer.java | 9 ++
> .../src/site/markdown/HDFSRouterFederation.md | 2 +-
> .../server/namenode/IsNameNodeActiveServlet.java | 33 ++++++++
> .../hdfs/server/namenode/NameNodeHttpServer.java | 3 +
> .../site/markdown/HDFSHighAvailabilityWithQJM.md | 8 ++
> .../IsResourceManagerActiveServlet.java | 38 +++++++++
> .../server/resourcemanager/ResourceManager.java | 5 ++
> .../resourcemanager/webapp/RMWebAppFilter.java | 3 +-
> .../src/site/markdown/ResourceManagerHA.md | 5 ++
> 12 files changed, 307 insertions(+), 2 deletions(-)
> {code}
> that commit has no changes to the cmd, whereas the merge commit does:
> {code}
> ± git show --stat 1363eff69c3 | cat
> commit 1363eff69c36c4f2085194b59a86370505cc00cd
> Merge: 94d7f90e93b 9af96d4ed4b
> Author: Konstantin V Shvachko <[email protected]>
> Date: Mon Sep 17 17:39:11 2018 -0700
> Merge commit '9af96d4ed4b6f80d3ca53a2b003d2ef768650dd4' into HDFS-12943
> # Conflicts:
> #
> hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md
> .../hadoop-common/src/main/bin/start-all.cmd | 104
> ++++++++++-----------
> .../hadoop-common/src/main/bin/stop-all.cmd | 104
> ++++++++++-----------
> .../org/apache/hadoop/http/IsActiveServlet.java | 71 ++++++++++++++
> .../apache/hadoop/http/TestIsActiveServlet.java | 95 +++++++++++++++++++
> .../federation/router/IsRouterActiveServlet.java | 37 ++++++++
> .../server/federation/router/RouterHttpServer.java | 9 ++
> .../src/site/markdown/HDFSRouterFederation.md | 2 +-
> .../hadoop-hdfs/src/main/bin/hdfs-config.cmd | 86 ++++++++---------
> .../hadoop-hdfs/src/main/bin/start-dfs.cmd | 82 ++++++++--------
> .../hadoop-hdfs/src/main/bin/stop-dfs.cmd | 82 ++++++++--------
> .../server/namenode/IsNameNodeActiveServlet.java | 33 +++++++
> .../hdfs/server/namenode/NameNodeHttpServer.java | 3 +
> .../site/markdown/HDFSHighAvailabilityWithQJM.md | 8 ++
> hadoop-mapreduce-project/bin/mapred-config.cmd | 86 ++++++++---------
> hadoop-tools/hadoop-streaming/src/test/bin/cat.cmd | 36 +++----
> .../hadoop-streaming/src/test/bin/xargs_cat.cmd | 36 +++----
> hadoop-yarn-project/hadoop-yarn/bin/start-yarn.cmd | 94 +++++++++----------
> hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.cmd | 94 +++++++++----------
> .../IsResourceManagerActiveServlet.java | 38 ++++++++
> .../server/resourcemanager/ResourceManager.java | 5 +
> .../resourcemanager/webapp/RMWebAppFilter.java | 3 +-
> .../src/site/markdown/ResourceManagerHA.md | 5 +
> 22 files changed, 709 insertions(+), 404 deletions(-)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
