[
https://issues.apache.org/jira/browse/HDDS-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630812#comment-16630812
]
Anu Engineer commented on HDDS-548:
-----------------------------------
[~ajayydv] Thanks for the review. Please see specific comments below.
{quote}Since this root certificate is private to this class don't we need
another api to handle this?
{quote}
Well, The root certificate is used to kick start the CA or a simple stand alone
system, like a SSL node. We will be creating a CA class that can take a CSR and
sign the certificates for the users. But that CA will need a self-signed or a
Root CA certificate provided. This patch is first of many that will create such
a system, hence the private signatures.
{quote}CertficateException: Typo in classname and constructor.
{quote}
Good catch, Fixed.
{quote}L69: Rename {{privateKeyName}} to {{privateKeyFileName}}?
{quote}
Done
{quote}L70: Rename {{publicKeyName}} to {{pubicKeyFileName?}}
{quote}
Done
{quote}L128: rename api {{getPublicKeyFileName}} to {{getPublicKeyFileName}}?
{quote}
Done
{quote}L138: rename getPrivateKeyName to getPrivateKeyFileName?
{quote}
Done.
The patch v6 takes care of all these issues.
> Create a Self-Signed Certificate
> --------------------------------
>
> Key: HDDS-548
> URL: https://issues.apache.org/jira/browse/HDDS-548
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: SCM
> Affects Versions: 0.2.1
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Priority: Major
> Attachments: HDDS-548-HDDS-4.001.patch, HDDS-548-HDDS-4.002.patch,
> HDDS-548-HDDS-4.003.patch, HDDS-548-HDDS-4.004.patch,
> HDDS-548-HDDS-4.005.patch, HDDS-548-HDDS-4.006.patch, HDDS-548.001.patch
>
>
> This Jira proposes to create a class that can create a self-signed
> certificate that can help with testing and can also act as a CA. This is
> needed to bootstrap SCM in the absence of a user provided CA certificate and
> is also needed for testing.
> cc: [~ajayydv], [~xyao]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
