[ 
https://issues.apache.org/jira/browse/HDDS-551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631154#comment-16631154
 ] 

Hanisha Koneru commented on HDDS-551:
-------------------------------------

Thanks [~shashikant] for working on this. 

LGTM. +1

(There is one checkstyle issue - line longer than 80, in 
CloseContainerCommandHandler#83. I will fix it while committing).

> Fix the close container status check in CloseContainerCommandHandler
> --------------------------------------------------------------------
>
>                 Key: HDDS-551
>                 URL: https://issues.apache.org/jira/browse/HDDS-551
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Datanode
>            Reporter: Shashikant Banerjee
>            Assignee: Shashikant Banerjee
>            Priority: Major
>         Attachments: HDDS-551.000.patch
>
>
> If the container is already closed while retrying to close the container in a 
> Datanode which is not a leader, we just log the info and still submit the 
> close request to Ratis. Ideally, this check should be moved to 
> CloseContainerCommandhandler and we should just return without submitting any 
> request.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to