[
https://issues.apache.org/jira/browse/HDDS-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631335#comment-16631335
]
Anu Engineer commented on HDDS-525:
-----------------------------------
[~bharatviswa] Thanks for the update, I have some minor comments on this patch.
# Should we add s3Config is a generic config and add also to ozone-site.xml?
# Not part of this patch, but shouldn't we add S3GatewayConfig to our standard
config tests? that is if we add key without the corresponding entry in
ozone-site.xml, we should get a failure? What do you think?
# VirtualHostStyleFilter#getDomainName() --
Suppose I have two domains, "a.b.com" and "b.com", I am worried that it is
possible for us to match "b.com" and return that as the domain even if the
request domain was "a.b.com." I am wondering if we should match the domain with
the longest match. In most cases this would not be a problem, just something
that occurred to me while reading code.
# VirtualHostStyleFilter#Line 84: Should we add a check if volume and bucket
are not blank or null, something like isNotBlank from Strings.
# It might be a good idea to write more some tests for example,
## Case where there is no key - something like the URI in create bucket.
## Case where there is a malformed URI -- for example , we have host but no
bucket and volume.
## Case where we have host, but only volume and no bucket.
## Case where we have a host HTTP header, but no domain attached to it.
> Support virtual-hosted style URLs
> ---------------------------------
>
> Key: HDDS-525
> URL: https://issues.apache.org/jira/browse/HDDS-525
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Assignee: Bharat Viswanadham
> Priority: Major
> Attachments: HDDS-525.00.patch, HDDS-525.02.patch, HDDS-525.03.patch
>
>
> AWS supports to kind of pattern for the base url of the s3 rest api:
> virtual-hosted style and path-style.
> Path style: http://s3.us-east-2.amazonaws.com/bucket
> Virtual-hosted style: http://bucket.s3.us-east-2.amazonaws.com
> By default we support the path style method with the volume name in the url:
> http://s3.us-east-2.amazonaws.com/volume/bucket
> Here the endpoint url is http://s3.us-east-2.amazonaws.com/volume/ and the
> bucket is appended.
> Some of the 3rd party s3 tools (goofys is an example) Supports only the
> virtual style method. With goofys we can set a custom endpoint
> (http://localhost:9878) but all the other postfixes after the port are
> removed.
> It can be solved with using virtual-style url which also could include the
> volume name:
> http://bucket.volume..........com
> The easiest way is to support both of them is implementing a
> ContainerRequestFilter which can parse the hostname (based on a configuration
> value) and extend the existing url with adding the missing volume/bucket
> part.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
