[ 
https://issues.apache.org/jira/browse/HDFS-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086149#comment-13086149
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-1257:
----------------------------------------------

TestProtectedBlockManager still has some problems.

- There was an AssertionError in [build 
#1107|https://builds.apache.org/job/PreCommit-HDFS-Build/1107/testReport/org.apache.hadoop.hdfs/TestProtectedBlockManager/testProtectedBlockManager/].
{noformat}
Exception in thread "Thread-278" java.lang.AssertionErro...[truncated 201 
chars]...ue(Assert.java:43)
        at 
org.apache.hadoop.hdfs.TestProtectedBlockManager$Workload.run(TestProtectedBlockManager.java:171)
Exception in thread "Thread-281" java.lang.AssertionError: 
java.lang.AssertionError: ----- File 0.14402 has 3 blocks:  The 0 block has 
only 2 replicas but is expected to have 3 replicas.
        at org.junit.Assert.fail(Assert.java:91)
        at org.junit.Assert.assertTrue(Assert.java:43)
        at 
org.apache.hadoop.hdfs.TestProtectedBlockManager$Workload.run(TestProtectedBlockManager.java:171)
{noformat}

- It still timed out in my machine.

If it is too hard to add a new test, how about we remove it?

> Race condition on FSNamesystem#recentInvalidateSets introduced by HADOOP-5124
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-1257
>                 URL: https://issues.apache.org/jira/browse/HDFS-1257
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.23.0
>            Reporter: Ramkumar Vadali
>            Assignee: Eric Payne
>             Fix For: 0.23.0
>
>         Attachments: HDFS-1257.1.20110810.patch, HDFS-1257.2.20110812.patch, 
> HDFS-1257.3.20110815.patch, HDFS-1257.4.20110816.patch, HDFS-1257.patch
>
>
> HADOOP-5124 provided some improvements to FSNamesystem#recentInvalidateSets. 
> But it introduced unprotected access to the data structure 
> recentInvalidateSets. Specifically, FSNamesystem.computeInvalidateWork 
> accesses recentInvalidateSets without read-lock protection. If there is 
> concurrent activity (like reducing replication on a file) that adds to 
> recentInvalidateSets, the name-node crashes with a 
> ConcurrentModificationException.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to