[ 
https://issues.apache.org/jira/browse/HDFS-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086330#comment-13086330
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-2265:
----------------------------------------------

Do you mean using try-finally to close the stream?  It is fine in unit test 
since if there is an IOException, the test fails and then the junit framework 
will clean up the everything.  Okay?

Regarding to private APIs in the tests, let's ignore it for the moment and 
spend our energy on the main code.

> Remove unnecessary BlockTokenSecretManager fields/methods from BlockManager
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-2265
>                 URL: https://issues.apache.org/jira/browse/HDFS-2265
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h2265_20110816.patch, h2265_20110816b.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to