[ 
https://issues.apache.org/jira/browse/HDFS-13713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16635374#comment-16635374
 ] 

Ewan Higgs commented on HDFS-13713:
-----------------------------------

{quote}Either the MPU rejects a second attempt to write to the destination 
(which the filesystem one now does){quote}

>From a contract perspective, this should overwrite.

{quote}Fix up FileSystemMultipartUploader to detect concurrent uploads and fail 
(it just looks for the completion dir & rejects if it exists){quote} 

This should succeed.

{quote}New test for concurrent uploads and ordering of visibility (eventually 
the last upload committed will be come and remain the final file){quote}
+1

{quote}n TestHDFSContractMultipartUploader.testUploadEmptyBlock() expect a 
failure, downgrade to WARN and skip(). This will need fixing in 3.3; for now 
just skip that test. See HDFS-13936{quote}
+1



> Add specification of Multipart Upload API to FS specification, with contract 
> tests
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-13713
>                 URL: https://issues.apache.org/jira/browse/HDFS-13713
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: fs, test
>    Affects Versions: 3.2.0
>            Reporter: Steve Loughran
>            Assignee: Ewan Higgs
>            Priority: Blocker
>         Attachments: HADOOP-13713-004.patch, HADOOP-13713-004.patch, 
> HADOOP-13713-005.patch, HADOOP-13713-006.patch, HADOOP-13713-007.patch, 
> HDFS-13713.001.patch, HDFS-13713.002.patch, HDFS-13713.003.patch, 
> multipartuploader.md
>
>
> There's nothing in the FS spec covering the new API. Add it in a new .md file
> * add FS model with the notion of a function mapping (uploadID -> Upload), 
> the operations (list, commit, abort). The [TLA+ 
> mode|https://issues.apache.org/jira/secure/attachment/12865161/objectstore.pdf]l
>  of HADOOP-13786 shows how to do this.
> * Contract tests of not just the successful path, but all the invalid ones.
> * implementations of the contract tests of all FSs which support the new API.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to