[ 
https://issues.apache.org/jira/browse/HDFS-13947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637366#comment-16637366
 ] 

Hudson commented on HDFS-13947:
-------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15110 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/15110/])
HDFS-13947. Review of DirectoryScanner Class. Contributed by BELUGA (inigoiri: 
rev 1dc0adfac0ee4821c67366728c70be9b59477b0f)
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/TestProvidedImpl.java
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDirectoryScanner.java
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestListCorruptFileBlocks.java
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java
* (edit) 
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java


> Review of DirectoryScanner Class
> --------------------------------
>
>                 Key: HDFS-13947
>                 URL: https://issues.apache.org/jira/browse/HDFS-13947
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 3.2.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Major
>             Fix For: 3.3.0
>
>         Attachments: HDFS-13947.1.patch, HDFS-13947.2.patch, 
> HDFS-13947.3.patch, HDFS-13947.4.patch, HDFS-13947.5.patch
>
>
> Review of Directory Scanner.   Replaced a lot of code with Guava MultiMap.  
> Some general house cleaning and improved logging.  For performance, using 
> {{ArrayList}} instead of {{LinkedList}} where possible, especially since 
> these lists can be quite large a LinkedList will consume a lot of memory and 
> be slow to sort/iterate over.
> https://stackoverflow.com/questions/322715/when-to-use-linkedlist-over-arraylist-in-java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to