[
https://issues.apache.org/jira/browse/HDFS-13958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638473#comment-16638473
]
Íñigo Goiri commented on HDFS-13958:
------------------------------------
I went through [^HDFS-13958.1.patch] and the changes look good.
The only one I had questions was removing the return for {{compileReport}} but
it doesn't seem to be used anywhere.
For the unit tests, it looks fine to me.
We should open a JIRA for {{TestNameNodeMetadataConsistency}}.
The changes in {{ProvidedVolumeImpl}} look straightforward but I'd like
[~virajith] to take a second look.
> Miscellaneous Improvements for FsVolumeSpi
> ------------------------------------------
>
> Key: HDFS-13958
> URL: https://issues.apache.org/jira/browse/HDFS-13958
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.3.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Major
> Attachments: HDFS-13958.1.patch
>
>
> The work in [HDFS-13947] allowed for using {{ArrayList}} instead of
> {{LinkedList}} when scanning DataNode local directories, however the
> {{FsVolumeSpi}} implementations were still using (and forcing)
> {{LinkedList}}. I propose changing the {{FsVolumeSpi}} signatures to allow
> for {{Collection}} instead of {{LinkedList}}. Since I'm looking at the code,
> I made some small improvements and check-style fixes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
