[
https://issues.apache.org/jira/browse/HDFS-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086756#comment-13086756
]
Hadoop QA commented on HDFS-2260:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490728/hdfs-2260.txt
against trunk revision 1158933.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 15 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings
org.apache.hadoop.hdfs.TestHDFSServerPorts
+1 contrib tests. The patch passed contrib unit tests.
-1 system test framework. The patch failed system test framework compile.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1115//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1115//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1115//console
This message is automatically generated.
> Refactor BlockReader into an interface and implementation
> ---------------------------------------------------------
>
> Key: HDFS-2260
> URL: https://issues.apache.org/jira/browse/HDFS-2260
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs client
> Affects Versions: 0.23.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hdfs-2260.txt, hdfs-2260.txt, hdfs-2260.txt
>
>
> For the new block reader in HDFS-2129, or the local block reader in HDFS-347,
> we need to be able to support different implementations. This JIRA is to
> simply refactor the current BlockReader into an interface and an
> implementation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
