[ 
https://issues.apache.org/jira/browse/HDFS-13878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640507#comment-16640507
 ] 

Wei-Chiu Chuang commented on HDFS-13878:
----------------------------------------

Thanks for the patch [~smeng] the patch is good and just a few nits:

{code:title= BaseTestHttpFSWith#testGetSnapshottableDirListing}
Path path2 = new Path("/tmp/tmp-snap-dirlist-test-2");
{code}
Is this a duplicate code? It doesn't look like the test utlizes path2 to do 
anything useful with httpfs/webhdfs. Same for 
TestHttpFSServer#testGetSnapshottableDirectoryList

> HttpFS: Implement GETSNAPSHOTTABLEDIRECTORYLIST
> -----------------------------------------------
>
>                 Key: HDFS-13878
>                 URL: https://issues.apache.org/jira/browse/HDFS-13878
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: httpfs
>            Reporter: Siyao Meng
>            Assignee: Siyao Meng
>            Priority: Major
>         Attachments: HDFS-13878.001.patch, HDFS-13878.002.patch
>
>
> Implement GETSNAPSHOTTABLEDIRECTORYLIST  (from HDFS-13141) in HttpFS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to