[ 
https://issues.apache.org/jira/browse/HDDS-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16640951#comment-16640951
 ] 

Ajay Kumar edited comment on HDDS-103 at 10/7/18 2:06 AM:
----------------------------------------------------------

[~anu] thanks for review.
{quote}Should we have a different protocol or should we put this as part of 
Heartbeat? Maybe we need both, I am not sure how the current code will be used.
{quote}
Main idea behind having separate protocol is to allow different authentication 
mechanism for initial CSR signing (and other similar calls). This will delink 
security handling of other 3 protocols.
{quote}
2. message SCMGetDataNodeCertResponseProto – The data type of certificate 
should be string instead of bytes. x509Certificate
Same for CSR later – it should be a string too.
3. nit: csr should be capital, since it is an acronym.{quote}
Done in patch v1.


was (Author: ajayydv):
[~anu] thanks for review.
{quote}Should we have a different protocol or should we put this as part of 
Heartbeat? Maybe we need both, I am not sure how the current code will be used.
{quote}
Idea behind having separate protocol is to allow different authentication 
mechanism for initial CSR signing (and other similar calls). This will delink 
security handling of other 3 protocols.
{quote}
2. message SCMGetDataNodeCertResponseProto – The data type of certificate 
should be string instead of bytes. x509Certificate
Same for CSR later – it should be a string too.
3. nit: csr should be capital, since it is an acronym.{quote}
Done in patch v1.

> SCM CA: Add new security protocol for SCM to expose security related functions
> ------------------------------------------------------------------------------
>
>                 Key: HDDS-103
>                 URL: https://issues.apache.org/jira/browse/HDDS-103
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Xiaoyu Yao
>            Assignee: Ajay Kumar
>            Priority: Major
>         Attachments: HDDS-103-HDDS-4.00.patch, HDDS-103-HDDS-4.01.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to