[ 
https://issues.apache.org/jira/browse/HDFS-13962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641620#comment-16641620
 ] 

Surendra Singh Lilhore commented on HDFS-13962:
-----------------------------------------------

Attached V1 patch. please review..

> Add null check for add-replica pool to avoid lock acquiring
> -----------------------------------------------------------
>
>                 Key: HDFS-13962
>                 URL: https://issues.apache.org/jira/browse/HDFS-13962
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.1.1
>            Reporter: Yiqun Lin
>            Assignee: Surendra Singh Lilhore
>            Priority: Major
>         Attachments: HDFS-13962.01.patch
>
>
> This is a follow-up work for HDFS-13768. Mainly two places needed to update:
>  * Add null check for add-replica pool to avoid lock acquiring
>  * In {{ReplicaMap#addAndGet}}, it would be better to use 
> {{FoldedTreeSet#addOrReplace}} instead of {{FoldedTreeSet#add}} for adding 
> replica info. This is for the logic consistentency with add operation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to