[
https://issues.apache.org/jira/browse/HDDS-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641890#comment-16641890
]
Elek, Marton commented on HDDS-521:
-----------------------------------
+1
I tested it and it works well. (I just learned from this patch the
Response.ok() is converted to 206 in case of missing body).
I have two suggestions but I will open follow-up jiras:
1.) I would like to handle the x-amz-request-id/x-amz-id-2 headers in a more
transparent way. (in CommonHeadersContainerResponseFilter + saving the
generated id request id in a request scoped holder)
2.) The exception handling should be improved. There is no <Resource> tag in
the response but resource specific tags (like <BucketName>) I checked the
documentation and it's very confusing the <Resource> seems to be the right tag,
but when I tested the awscli with the original aws s3 endpoint and checked the
response with mitmproxy I found that it's more sophisticated.
But both of these are related to multiple endpoints not about the delete
bucket: I will commit it shortly and open the follow-up jiras.
> Implement DeleteBucket REST endpoint
> ------------------------------------
>
> Key: HDDS-521
> URL: https://issues.apache.org/jira/browse/HDDS-521
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: newbie
> Attachments: HDDS-521.00.patch, HDDS-521.01.patch
>
>
> The delete bucket will do the opposite of the create bucket call. It will
> locate the volume via the username in the delete call.
> Reference is here:
> https://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketDELETE.html
> This is implemented as part of HDDS-444 but we need the double check the
> headers and add acceptance tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
