[
https://issues.apache.org/jira/browse/HDFS-13967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642105#comment-16642105
]
Íñigo Goiri edited comment on HDFS-13967 at 10/8/18 4:36 PM:
-------------------------------------------------------------
Than change looks like it keeps the same functionality and it adds a couple
null checks which is always good.
The only part that concerns me is that now we use a HashMap order for the
{{validLocations}} which I don't think is critical for this code though.
This LGTM but I'd like [~linyiqun] to take a look to double check.
was (Author: elgoiri):
Than change looks like it keeps the same functionality and it adds a couple
null checks which is always good.
This LGTM but I'd like [~linyiqun] to take a look to double check.
> HDFS Router Quota Class Review
> ------------------------------
>
> Key: HDFS-13967
> URL: https://issues.apache.org/jira/browse/HDFS-13967
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: federation, hdfs
> Affects Versions: 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HDFS-13967.1.patch
>
>
> # Use Guava library
> # Prefer ArrayList over LinkedList
> # Simplify code logic
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
