[
https://issues.apache.org/jira/browse/HDDS-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642026#comment-16642026
]
Shashikant Banerjee edited comment on HDDS-450 at 10/8/18 4:58 PM:
-------------------------------------------------------------------
Patch v2 removes the blockCommitSequenceId filed from
GetCommittedBlockLengthRequestProto. Adding to the discussion above, the
blockCommitSequenceId field is added during applyTransaction call only, the
containerRequestProto object need to be reconstructed during this call
irrespective of whether blockCommitSequenceId field is inside
containerRequestProto or not. As per offline discussion with [~msingh] as well,
i would like to maintain blockCommitSequenceId field to be maintained inside
DataBlock proto structure and returned in the PutBlock response.
was (Author: shashikant):
Patch v2 removes the blockCommitSequenceId filed from
GetCommittedBlockLengthRequestProto. Adding to the discussion above, the
blockCommitSequenceId field is added during containerRequest proto object
applyTransaction call only, the containerRequestProto need to be reconstructed
during this call irrespective of whether blockCommitSequenceId field is inside
containerRequestProto or not. I prefer blockCommitSequenceId field to be
maintained inside DataBlock proto structure and returned in the PutBlock
response.
> Generate BlockCommitSequenceId in ContainerStateMachine for every commit
> operation in Ratis Leader
> --------------------------------------------------------------------------------------------------
>
> Key: HDDS-450
> URL: https://issues.apache.org/jira/browse/HDDS-450
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Attachments: HDDS-450.001.patch, HDDS-450.002.patch
>
>
> BlockCommitSequenceId will be increasing long value generated in the Ratis
> leader for every commit operation of a block and will be replicated over to
> the followers. This id will be updated in OM and will be reported to SCM
> which will help the most consistent copy of a open container replica in case
> the majority of the datanodes fail.
> The blockCommitSequenceId is same as the commit index of the flush(PUT_BLOCK)
> transaction in Ratis.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
