[
https://issues.apache.org/jira/browse/HDFS-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13086816#comment-13086816
]
Hadoop QA commented on HDFS-2129:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12490744/hdfs-2129.txt
against trunk revision 1159004.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
-1 javac. The applied patch generated 36 javac compiler warnings (more
than the trunk's current 35 warnings).
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings
org.apache.hadoop.hdfs.TestHDFSServerPorts
+1 contrib tests. The patch passed contrib unit tests.
-1 system test framework. The patch failed system test framework compile.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/1118//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HDFS-Build/1118//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1118//console
This message is automatically generated.
> Simplify BlockReader to not inherit from FSInputChecker
> -------------------------------------------------------
>
> Key: HDFS-2129
> URL: https://issues.apache.org/jira/browse/HDFS-2129
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs client
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.23.0
>
> Attachments: hdfs-2129-benchmark.png, hdfs-2129.txt, hdfs-2129.txt,
> hdfs-2129.txt, seq-read-1gb-bench.png
>
>
> BlockReader is currently quite complicated since it has to conform to the
> FSInputChecker inheritance structure. It would be much simpler to implement
> it standalone. Benchmarking indicates it's slightly faster, as well.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
