[
https://issues.apache.org/jira/browse/HDDS-585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642173#comment-16642173
]
Bharat Viswanadham edited comment on HDDS-585 at 10/8/18 5:16 PM:
------------------------------------------------------------------
Thank You, [~elek] for fixing this issue. Now, the code looks cleaner.
Few minor comments
1. RequestIdentifier.java, Typo in comments Line 27
2. TestOS3Exception needs to be modified for change in OS3Exception
constructor change. (Because of this code, there are compilation errors)
was (Author: bharatviswa):
Thank You, [~elek] for fixing this issue. Now, the code looks cleaner.
Few minor comments
1. RequestIdentifier.java, Typo in comments Line 27
2. TestOS3Exception needs to be modified for change in OS3Exception constructor
change.
> Handle common request identifiers in a transparent way
> ------------------------------------------------------
>
> Key: HDDS-585
> URL: https://issues.apache.org/jira/browse/HDDS-585
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Attachments: HDDS-585.001.patch
>
>
> As of now multiple endpoint contains the code to handle the amazon specific
> request id-s.
> {code}
> setRequestId(OzoneUtils.getRequestID());
> ...
> return Response.ok().status(HttpStatus.SC_NO_CONTENT).header(
> "x-amz-request-id", getRequestId()).header("x-amz-id-2",
> RandomStringUtils.randomAlphanumeric(8, 16)).build();
> {code}
> I propose to handle the request id generation + adding it to the headers in
> one location which is transparent for all the rest endpoints.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
