[ 
https://issues.apache.org/jira/browse/HDDS-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642677#comment-16642677
 ] 

Bharat Viswanadham edited comment on HDDS-577 at 10/9/18 1:29 AM:
------------------------------------------------------------------

Hi [~anu]

Thanks for the patch.

I have a question, do we needgetOzoneBucketName, as this is the same name as 
S3Bucketname only right. As in S3Table we store s3+<<user>>/bucketname. (Having 
getOzoneVolumeName looks needed, as this will return the volume name which we 
construct through mapping)

So do we need these API's or can we remove this.

LGTM, few things are missing in the patch.

 

*Added following changes in patch v02:*
 # Status code mapping from OzoneManagerProtocolClientSideTranslatorPB is 
missing added them.
 # These new methods needs to be added to ObjectStore, as we use ozoneclient in 
S3Gateway API requests.
 # Added test cases for new S3 API's.

 

 

[~elek]

Let me know your thoughts on the v02 patch.


was (Author: bharatviswa):
Hi [~anu]

Thanks for the patch.

I have a question, do we needgetOzoneBucketName, as this is the same name as 
S3Bucketname only right. As in S3Table we store s3+<<user>>/bucketname. (Having 
getOzoneVolumeName looks needed, as this will return the volume name which we 
construct through mapping)

So do we need these API's or can we remove this.

LGTM, few things are missing in the patch.
 # Status code mapping from OzoneManagerProtocolClientSideTranslatorPB is 
missing added them.
 # These new methods needs to be added to ObjectStore, as we use ozoneclient in 
S3Gateway API requests.
 # Added test cases for new S3 API's.

 

 

[~elek]

Let me know your thoughts on the v02 patch.

> Support S3 buckets as first class objects in Ozone Manager - 2
> --------------------------------------------------------------
>
>                 Key: HDDS-577
>                 URL: https://issues.apache.org/jira/browse/HDDS-577
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: S3
>            Reporter: Anu Engineer
>            Assignee: Anu Engineer
>            Priority: Major
>         Attachments: HDDS-577.001.patch, HDDS-577.02.patch
>
>
> This patch is a continuation of HDDS-572. The earlier patch created S3 API 
> support for Ozone Manager, this patch exposes that API to the RPC client. In 
> the next few patches we will add support for S3Gateway and MiniOzone based 
> testing.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to