[
https://issues.apache.org/jira/browse/HDFS-13949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644018#comment-16644018
]
Nanda kumar commented on HDFS-13949:
------------------------------------
[~brfrn169], We use {{dfs.datanode.disk.check.timeout}} in two places;
DatasetVolumeChecker#checkAllVolumes and StorageLocationChecker#check.
{{StorageLocationChecker#check}} is called from {{DataNode#makeInstance}} which
is as part of datanode start-up.
{{DatasetVolumeChecker#checkAllVolumes}} is called from
{{DataNode#checkDiskError}} when we do {{DataNode#initBlockPool}}, this happens
when a datanode is able to successfully register with a NameNode. This should
also be ideally considered as datanode start-up, as it is done only when we
first register with the NameNode.
Is there anywhere else this property has been used and I'm missing it?
> Correct the description of dfs.datanode.disk.check.timeout in hdfs-default.xml
> ------------------------------------------------------------------------------
>
> Key: HDFS-13949
> URL: https://issues.apache.org/jira/browse/HDFS-13949
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: documentation
> Reporter: Toshihiro Suzuki
> Assignee: Toshihiro Suzuki
> Priority: Minor
> Attachments: HDFS-13949.1.patch
>
>
> The description of dfs.datanode.disk.check.timeout in hdfs-default.xml is as
> follows:
> {code}
> <property>
> <name>dfs.datanode.disk.check.timeout</name>
> <value>10m</value>
> <description>
> Maximum allowed time for a disk check to complete during DataNode
> startup. If the check does not complete within this time interval
> then the disk is declared as failed. This setting supports
> multiple time unit suffixes as described in dfs.heartbeat.interval.
> If no suffix is specified then milliseconds is assumed.
> </description>
> </property>
> {code}
> I don't think the value of this config is used only during DataNode startup.
> I think it's used whenever checking volumes.
> The description is misleading so we need to correct it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
