[
https://issues.apache.org/jira/browse/HDFS-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647235#comment-16647235
]
Konstantin Shvachko commented on HDFS-13925:
--------------------------------------------
Comments on patch v3:
# Should not import all assert methods, like {{Assertions.*}}, when you need
only one {{fail()}}.
# Looks like you picked a wrong {{fail()}} method. It should be
{{org.junit.Assert.fail}} rather than {{org.assertj}}.
# What is the reason for resetting {{setObserverRead(false)}}? The {{setUp()}}
method sets {{setObserverRead(true)}} before every test case, which should work
for you cases?
> Unit Test for transitioning between different states
> ----------------------------------------------------
>
> Key: HDFS-13925
> URL: https://issues.apache.org/jira/browse/HDFS-13925
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Sherwood Zheng
> Assignee: Sherwood Zheng
> Priority: Major
> Attachments: HDFS-13925-HDFS-12943.000.patch,
> HDFS-13925-HDFS-12943.001.patch, HDFS-13925-HDFS-12943.002.patch,
> HDFS-13925-HDFS-12943.003.patch
>
>
> adding two unit tests:
> 1. Ensure that Active cannot be transitioned to Observer and vice versa.
> 2. Ensure that Observer can be transitioned to Standby and vice versa.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
