[
https://issues.apache.org/jira/browse/HDDS-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647540#comment-16647540
]
Jitendra Nath Pandey commented on HDDS-579:
-------------------------------------------
1.
{quote} (cont.getContainerState() == ContainerLifeCycleState.OPEN ||
isUnhealthy)
{quote}
The condition should be OPEN && Unhealthy to make it eligible for close. I
understand that isUnHealthy is checked again later, but this makes code
confusing.
In method {{sendCloseContainerActionIfNeeded,}} I would suggest the check for
unhealthy should also happen for open containers only, similar to the previous
implementation. The {{reason}} should be looked up by a separate method using a
switch statement.
Also, it seems the condition for full container is already checked at Line 133.
May be it is cleaner if there are two methods, one checks for unhealthy and
another checks for container full.
2. From the patch it seems, the container is just marked unhealthy and close
action is initiated, subsequent transactions are not really failed promptly,
until the container is marked for close. I think unhealthy replica should just
stop applying any more transactions.
> ContainerStateMachine should fail subsequent transactions per container in
> case one fails
> -----------------------------------------------------------------------------------------
>
> Key: HDDS-579
> URL: https://issues.apache.org/jira/browse/HDDS-579
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Labels: recovery
> Attachments: HDDS-579.000.patch
>
>
> ContainerStateMachine will keep of track of the last successfully applied
> transaction index and on restart inform Ratis the index, so that the
> subsequent transactions can be reapplied from here.
> Moreover, in case one transaction fails, all the subsequent transactions on
> the container should fail in the containerStateMachine and a container close
> action to SCM needs to be initiated to close the container.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
