[
https://issues.apache.org/jira/browse/HDFS-13980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648254#comment-16648254
]
BELUGA BEHR commented on HDFS-13980:
------------------------------------
Ha. The only unit test that failed in both runs was
{{hadoop.fs.TestHdfsNativeCodeLoader}} and that is known to be flaky. Please
consider this patch for inclusion into the project.
> Review of DBNameNodeConnector Class
> -----------------------------------
>
> Key: HDFS-13980
> URL: https://issues.apache.org/jira/browse/HDFS-13980
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: diskbalancer
> Affects Versions: 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HDFS-13980.1.patch, HDFS-13980.2.patch
>
>
> * Removed anti-pattern "log and throw". Log or throw, don't do both
> * Use pre-sized {{ArrayList}} instead of {{LinkedList}}
> * Fixed some formatting issues
> * Re-ordered imports into correct order
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
