[
https://issues.apache.org/jira/browse/HDDS-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649283#comment-16649283
]
Shashikant Banerjee commented on HDDS-629:
------------------------------------------
Thanks [~jnp], for the review comments.
{code:java}
In ChunkUtils.java, the chunkfile is being truncated to zero length. It is
possible that the chunk being overwritten starts from an offset. The code
assumes that every chunkInfo is for a new file and offset is always zero.
Is added TODO statement meant for the above?
{code}
Currently, by default the overwrite of a chunk file is not permitted. Once we
have the feature to overwrite the chunk file, we need to handle the case. The
TODO is added for the same.
Patch addresses rest of the review comments.
> Make ApplyTransaction calls in ContainerStateMachine idempotent
> ---------------------------------------------------------------
>
> Key: HDDS-629
> URL: https://issues.apache.org/jira/browse/HDDS-629
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Attachments: HDDS-629.000.patch, HDDS-629.001.patch,
> HDDS-629.002.patch
>
>
> When a Datanode restarts, it may lead up to a case where it can reapply
> already applied Transactions when it joins the pipeline again . For this
> requirement, all ApplyTransaction calls in Ratis need to be made idempotent
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
