[
https://issues.apache.org/jira/browse/HDDS-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652185#comment-16652185
]
Hudson commented on HDDS-378:
-----------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15227 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/15227/])
HDDS-378. Remove dependencies between hdds/ozone and hdfs proto files. (arp:
rev 5f0b43fa93d02c90956d48eb5c6c0b60deeac91c)
* (edit) hadoop-ozone/common/pom.xml
* (edit)
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketArgs.java
* (edit) hadoop-hdds/container-service/pom.xml
* (edit)
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/client/rest/response/BucketInfo.java
* (edit)
hadoop-hdds/common/src/main/proto/StorageContainerLocationProtocol.proto
* (edit)
hadoop-ozone/objectstore-service/src/main/java/org/apache/hadoop/ozone/web/handlers/BucketProcessTemplate.java
* (edit) hadoop-hdds/common/pom.xml
* (edit) hadoop-hdds/common/src/main/proto/ScmBlockLocationProtocol.proto
* (edit)
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestMultipleContainerReadWrite.java
* (edit)
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/BucketArgs.java
* (edit)
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/client/OzoneVolumeStub.java
* (edit)
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/protocol/ClientProtocol.java
* (edit)
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManager.java
* (edit)
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/web/response/BucketInfo.java
* (edit)
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
* (edit)
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestOzoneRpcClient.java
* (edit)
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOmBlockVersioning.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/S3BucketManagerImpl.java
* (edit)
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/web/handlers/BucketArgs.java
* (edit)
hadoop-ozone/common/src/test/java/org/apache/hadoop/ozone/web/TestBucketInfo.java
* (edit)
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestStorageContainerManagerHelper.java
* (edit)
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestBucketManagerImpl.java
* (add)
hadoop-ozone/common/src/main/java/org/apache/hadoop/hdds/protocol/StorageType.java
* (edit) hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
* (edit)
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneBucket.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java
* (edit)
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/client/OzoneBucketStub.java
* (edit)
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rest/RestClient.java
* (edit)
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketInfo.java
* (edit)
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rest/TestOzoneRestClient.java
> Remove dependencies between hdds/ozone and hdfs proto files
> -----------------------------------------------------------
>
> Key: HDDS-378
> URL: https://issues.apache.org/jira/browse/HDDS-378
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: newbie
> Fix For: 0.3.0, 0.4.0
>
> Attachments: HDDS-378.001.patch, HDDS-378.002.patch,
> HDDS-378.003.patch
>
>
> It would be great to make the hdds/ozone proto files independent from hdfs
> proto files. It would help as to start ozone with multiple version of hadoop
> version.
> Also helps to make artifacts from the hdds protos: HDDS-220
> Currently we have a few unused "hdfs.proto" import in the proto files and we
> use the StorageTypeProto from hdfs:
> {code}
> cd hadoop-hdds
> grep -r "hdfs" --include="*.proto"
> common/src/main/proto/ScmBlockLocationProtocol.proto:import "hdfs.proto";
> common/src/main/proto/StorageContainerLocationProtocol.proto:import
> "hdfs.proto";
> cd ../hadoop-ozone
> grep -r "hdfs" --include="*.proto"
> common/src/main/proto/OzoneManagerProtocol.proto:import "hdfs.proto";
> common/src/main/proto/OzoneManagerProtocol.proto: required
> hadoop.hdfs.StorageTypeProto storageType = 5 [default = DISK];
> common/src/main/proto/OzoneManagerProtocol.proto: optional
> hadoop.hdfs.StorageTypeProto storageType = 6;
> {code}
> I propose to
> 1.) remove the hdfs import statements from the proto files
> 2.) Copy the StorageTypeProto and create a Hdds version from it (without
> PROVIDED)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
