[ 
https://issues.apache.org/jira/browse/HDFS-13941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652245#comment-16652245
 ] 

Arpit Agarwal commented on HDFS-13941:
--------------------------------------

Looks like there is a regression in the following method, an if block got 
dropped.
{code}
  public void checkAccess(BlockTokenIdentifier id, String userId,
      ExtendedBlock block, BlockTokenIdentifier.AccessMode mode,
      StorageType[] storageTypes, String[] storageIds) throws InvalidToken {
{code}

It no longer checks for storageTypes.



> make storageId in BlockPoolTokenSecretManager.checkAccess optional
> ------------------------------------------------------------------
>
>                 Key: HDFS-13941
>                 URL: https://issues.apache.org/jira/browse/HDFS-13941
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ajay Kumar
>            Assignee: Ajay Kumar
>            Priority: Major
>         Attachments: HDFS-13941.00.patch, HDFS-13941.01.patch
>
>
>  change in {{BlockPoolTokenSecretManager.checkAccess}} by 
> [HDDS-9807|https://issues.apache.org/jira/browse/HDFS-9807] breaks backward 
> compatibility for Hadoop 2 clients. Since SecretManager is marked for public 
> audience we should add a overloaded function to allow Hadoop 2 clients to 
> work with it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to