[
https://issues.apache.org/jira/browse/HDDS-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652266#comment-16652266
]
Arpit Agarwal commented on HDDS-544:
------------------------------------
This looks like a nice catch by findbugs. If a task is added after the worker
thread calls selectTask but before it calls wait.
We probably need to change the synchronization logic in ReplicationSupervisor.
> Unconditional wait findbug warning from ReplicationSupervisor
> -------------------------------------------------------------
>
> Key: HDDS-544
> URL: https://issues.apache.org/jira/browse/HDDS-544
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Blocker
>
> We have a findbug warning in ReplicationSupervisor:
> {code}
> Multithreaded correctness Warnings
> Code Warning
> UW Unconditional wait in
> org.apache.hadoop.ozone.container.replication.ReplicationSupervisor$Worker.run()
>
> Details
> UW_UNCOND_WAIT: Unconditional wait
> This method contains a call to java.lang.Object.wait() which is not guarded
> by conditional control flow. The code should verify that condition it
> intends to wait for is not already satisfied before calling wait; any
> previous notifications will be ignored
> {code}
> This issue is to fix it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
