[ 
https://issues.apache.org/jira/browse/HDFS-13942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652998#comment-16652998
 ] 

Akira Ajisaka commented on HDFS-13942:
--------------------------------------

Thanks [~dineshchitlangia] for the patch!

bq. I am not able to see StoragePolicySatisfyWorker in trunk and thus this 
error appears to linger
StoragePolicySatisfyWorker was removed by 
https://github.com/apache/hadoop/commit/39ed3a66dbb01383ed16b141183fc48bfd2e613d.
 IMO, ExternalSPSBlockMoveTaskHandler is the successor.

bq. MoreExecutors#newDirectExecutorService() is available in newer versions of 
the Guava Google core libraries and thus depending on the version, the error 
may persist.
Let's remove the sentence. In addition, {{@since 18.0}} should be removed 
because 18.0 is not the version of Apache Hadoop.

Some comments:
* In BlockListAsLongs.java, {{<Long<}} should be {{<Long>}}.
* In DataStorage.java,
{noformat}
* {@link VolumeBuilder#prepareVolume(DataNode, StorageLocation, List)}.
{noformat}
VolumeBuilder is not needed. {{{@link #prepareVolume(DataNode, StorageLocation, 
List)}} is sufficient.
* In Quota.java, {{delta < 0}} should be {{delta > 0}}.
* In XAttrStorage.java,
{noformat} 
* @return {@literal List<XAttr>} {@code XAttr} list.
{noformat}
Return type {{{@literal List<XAttr>}}} is not needed because the information is 
documented to JavaDoc automatically.


> [JDK10] Fix javadoc errors in hadoop-hdfs module
> ------------------------------------------------
>
>                 Key: HDFS-13942
>                 URL: https://issues.apache.org/jira/browse/HDFS-13942
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: documentation
>            Reporter: Akira Ajisaka
>            Assignee: Dinesh Chitlangia
>            Priority: Major
>         Attachments: HDFS-13942.001.patch, HDFS-13942.002.patch
>
>
> There are 212 errors in hadoop-hdfs module.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to