[ https://issues.apache.org/jira/browse/HDDS-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16655990#comment-16655990 ]
Jitendra Nath Pandey commented on HDDS-676: ------------------------------------------- # What is the reason for changing clientCache key from PipelineId to string? # XceiverClientGrpc#isConnected : The three channels may each be in different state. # dnIndex is used in only one method, no need to be a class attribute. # In XceiverClientGrpc, we should create the channel and stub, just before making the cal in {{sendCommand}}, otherwise in majority of the cases, we would be opening unnecessary connection. # The changes in XceiverClientRatis are only for testing? # It is minor but I feel we should not make {{type}} mutable in the Pipeline class. We could clone the {{Pipeline}} object to change the type. # In {{ContainerStateMachine}} changes don't look related to this Jira as they are about put-small-files. If yes, we should put them in a separate jira. # Instead of INVALID_BCSID , we should call it UNKNOWN_BCSID. Client has obtained it from OM, so it is likely a valid one, but container doesn't have it. We should also put the containerBcs in the error message. > Enable Read from open Containers via Standalone Protocol > -------------------------------------------------------- > > Key: HDDS-676 > URL: https://issues.apache.org/jira/browse/HDDS-676 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Reporter: Shashikant Banerjee > Assignee: Shashikant Banerjee > Priority: Major > Attachments: HDDS-676.001.patch > > > With BlockCommitSequenceId getting updated per block commit on open > containers in OM as well datanode, Ozone Client reads can through Standalone > protocol not necessarily requiring Ratis. Client should verify the BCSID of > the container which has the data block , which should always be greater than > or equal to the BCSID of the block to be read and the existing block BCSID > should exactly match that of the block to be read. As a part of this, Client > can try to read from a replica with a supplied BCSID and failover to the next > one in case the block does ont exist on one replica. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org