[ 
https://issues.apache.org/jira/browse/HDDS-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657443#comment-16657443
 ] 

Elek, Marton commented on HDDS-702:
-----------------------------------

bq. why can't we remove the parent from hadoop-hdds and hadoop-ozone pom.xml

We can, but we have useful conventions in hadoop-project such as 
checkstyle/findbugs/enforcement plugins. As we follow the main hadoop 
conventions it was easier. But we can change it if we will have more 
differences.

bq. I think we can commit this patch, as when Hadoop 3.2 gets released the only 
thing we need to change is to change hadoop.version to 3.2. (Not sure if any 
additional needs to be done)

One additional minor change: With changing to 3.2.0 we can remove the snapshot 
repository references. I added it to the hadoop-ozone/hadoop-hdds projects as 
it requires to download the snapshot parent (which also contains the snapshot 
repository entry, but only available after download). 3.2.0 will be synced with 
central and can work without the repository entries.

bq.  Should we wait until Apache Hadoop 3.2.0 is released so we can point to a 
non-snapshot version?

I agree with [~bharatviswa] we can commit it earlier. Even now we use snapshot 
versions from hadoop, just it's 3.3.0-SNAPSHOT. Better to start earlier this 
approach: hopefully we can include it in 0.3.0 (with hadoop 3.2.0) 

But I have no problem if you prefer to wait to 3.2.0. 

ps: I modified the configuration of the maven enforcer plugin in the patch. I 
have a very detailed comment in HDDS-691 about this change.

> Used fixed/external version from hadoop jars in hdds/ozone projects
> -------------------------------------------------------------------
>
>                 Key: HDDS-702
>                 URL: https://issues.apache.org/jira/browse/HDDS-702
>             Project: Hadoop Distributed Data Store
>          Issue Type: New Feature
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>         Attachments: HDDS-702.001.patch
>
>
> In the current form of the project ozone uses the in-tree snapshot version of 
> the hadoop (hadoop 3.3.0-SNAPSHOT as of now).
> I propose to use a fixed version from the hadoop jars which could be 
> independent from the in-tree hadoop.
> 1. With using already released hadoop (such as hadoop-3.1) we can upload the 
> ozone jar files to the maven repository without pseudo-releasing the hadoop 
> snapshot dependencies. (In the current form it's not possible without also 
> uploading a custom, ozone flavour of hadoop-common/hadoop-hdfs)
> 2. With using fixed version of hadoop the build could be faster and the yetus 
> builds could be simplified (it's very easy to identify the projects which 
> should be checked/tested if only the hdds/ozone projects are part of the 
> build: we can do full build/tests all the time).
> After the previous work it's possible to switch to fixed hadoop version, 
> because:
> 1) we have no more proto file dependency between hdds and hdfs (HDDS-378, and 
> previous works by Mukul and Nanda)
> 2) we don't need to depend on the in-tree hadoop-project-dist (HDDS-447)
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to