[ 
https://issues.apache.org/jira/browse/HDFS-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659136#comment-16659136
 ] 

Íñigo Goiri commented on HDFS-13981:
------------------------------------

Going over it again, the full class just for changing one value in a test still 
kills me...
I would create a class for the whole project for the space: 
{{NamenodeSpaceReport}}.
Then we can use it for both the code and the tests.

> Review of AvailableSpaceResolver.java
> -------------------------------------
>
>                 Key: HDFS-13981
>                 URL: https://issues.apache.org/jira/browse/HDFS-13981
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: federation
>    Affects Versions: 3.2.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HDFS-13981.1.patch, HDFS-13981.2.patch, 
> HDFS-13981.3.patch
>
>
> * No behavior changes, just optimizing and paring down the code



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to