[
https://issues.apache.org/jira/browse/HDDS-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659238#comment-16659238
]
Bharat Viswanadham edited comment on HDDS-573 at 10/22/18 6:08 PM:
-------------------------------------------------------------------
Hi [~danilocop]
Thank You for fixing this issue.
Patch LGTM. As discussed offline we can add a simple unit test for this new
change, where we can have URL with port, and config withoutthe port. So this
way we can check newly added code behavior.
Edit: I think no need of adding a new test, as the existing tests will fail
because
ozone.s3g.domain.name is set to s3 gateway http address. So, we need to update
it to remove the port name from it, to make tests pass. This will be enough to
test the new code.
was (Author: bharatviswa):
Hi [~danilocop]
Thank You for fixing this issue.
Patch LGTM. As discussed offline we can add a simple unit test for this new
change, where we can have URL with port, and config withoutthe port. So this
way we can check newly added code behavior.
> Make VirtualHostStyleFilter port agnostic
> -----------------------------------------
>
> Key: HDDS-573
> URL: https://issues.apache.org/jira/browse/HDDS-573
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Assignee: Danilo Perez
> Priority: Major
> Labels: newbie
> Attachments: HDDS-573.00.patch
>
>
> Based on the discussion in HDDS-525
> The host HTTP header sometimes contains the port, sometimes not (with aws cli
> we have the port, with mitm proxy we doesn't). Would be easier to remove it
> anyway to make it easier to configure the s3 gateway.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
