[
https://issues.apache.org/jira/browse/HDDS-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659791#comment-16659791
]
Bharat Viswanadham commented on HDDS-528:
-----------------------------------------
Over all patch LGTM.
I think integration tests are removed as part of HDDS-379, to add robot tests
for these commands.
I will open a new Jira to add robot tests for scm cli commands.
Few comments:
# Can we rename the classes to add ChillMode before their names?
# And right now to check whether scm is in chill mode with the patch provided
the command is ozone scmcli check, can we change it to ozone scm chillmode
check and ozone scm chillmode exit. So, chillmode will be a subcommand for
scmcli, and check/exit are subcommands of chillmode.
> add cli command to checkChill mode status and exit chill mode
> -------------------------------------------------------------
>
> Key: HDDS-528
> URL: https://issues.apache.org/jira/browse/HDDS-528
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Ajay Kumar
> Assignee: chencan
> Priority: Major
> Attachments: HDDS-528.001.patch
>
>
> [HDDS-370] introduces below 2 API:
> * isScmInChillMode
> * forceScmExitChillMode
> This jira is to call them via relevant cli command.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
