[
https://issues.apache.org/jira/browse/HDDS-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660180#comment-16660180
]
Nanda kumar commented on HDDS-695:
----------------------------------
[~anu] & [~linyiqun], thanks for the review.
{quote}There is a conflict on trunk, please rebase and feel free to commit.
{quote}
This patch is not for trunk, it is for branch ozone-0.3
{quote}For returning pipeline list in PipelineSelector, can we use
Collections.unmodifiableList(..) to return a unmodifiable list?
{quote}
Thanks for the suggestion, since we are returning a new ArrayList everytime
listPipelines is called, we don't have to worry even if someone modifies the
list. It doesn't affect us. Anyways it is better to restrict the access to the
returned list, modified the method to return unmodifiableList in patch v003.
{quote}Can we add a corresponding unit test for listPipelines api in
TestPipelineSelector as well?
{quote}
Added new test-cases for listPipelines in patch v003
> Introduce a new SCM Command to teardown a Pipeline
> --------------------------------------------------
>
> Key: HDDS-695
> URL: https://issues.apache.org/jira/browse/HDDS-695
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Priority: Blocker
> Attachments: HDDS-695-ozone-0.3.000.patch,
> HDDS-695-ozone-0.3.001.patch, HDDS-695-ozone-0.3.002.patch,
> HDDS-695-ozone-0.3.003.patch
>
>
> We need to have a tear-down pipeline command in SCM so that an administrator
> can close/destroy a pipeline in the cluster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
