[
https://issues.apache.org/jira/browse/HDDS-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663639#comment-16663639
]
Lokesh Jain commented on HDDS-361:
----------------------------------
[~hanishakoneru] Thanks for reviewing the patch! v3 patch addresses your
comments.
{quote}Instead, we should update {{numBlocksDeleted}} with the number of blocks
actually deleted in {{executeDeleteTxn}}
{quote}
The patch I have uploaded makes best effort to delete a block. On failure we
can consider two options.
# Retain the delete transaction in the db. We cannot update the number of
pending deletion blocks partially based on successful block deletions. If we
want to do it then we need to alter the delete transaction (to include only
blocks which could not be deleted). This altered transaction needs to be put
back into the db which is not a good idea. Therefore we can retain the entire
transaction on failure of block deletion
# We can ignore the block which could not be deleted and garbage collection
can handle this block deletion.
I think we should retain the entire delete transaction in case of failure in
deletion of any block. I have not made this change in the patch I have
uploaded. Please let me know your thoughts on it.
The patch also adds a new unit test TestDeleteBlockCommandHandler.
> Use DBStore and TableStore for DN metadata
> ------------------------------------------
>
> Key: HDDS-361
> URL: https://issues.apache.org/jira/browse/HDDS-361
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Xiaoyu Yao
> Assignee: Lokesh Jain
> Priority: Major
> Attachments: HDDS-361.001.patch, HDDS-361.002.patch,
> HDDS-361.003.patch
>
>
> As part of OM performance improvement we used Tables for storing a particular
> type of key value pair in the rocks db. This Jira aims to use Tables for
> separating block keys and deletion transactions in the container db.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
