[
https://issues.apache.org/jira/browse/HDFS-14029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Agarwal updated HDFS-14029:
---------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 3.2.1
3.3.0
3.1.2
3.0.4
Status: Resolved (was: Patch Available)
Thanks [~adam.antal]. +1
We typically use GenericTestUtils.waitFor or LambdaTestUtils.await as it wraps
the sleep and retry-loop however what you have works too.
The patch didn't cherry-pick to branch-2 cleanly so I skipped that. If you want
to provide a branch-2 patch I would be happy to commit it too.
> Sleep in TestLazyPersistFiles should be put into a loop
> -------------------------------------------------------
>
> Key: HDFS-14029
> URL: https://issues.apache.org/jira/browse/HDFS-14029
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Reporter: Adam Antal
> Assignee: Adam Antal
> Priority: Trivial
> Labels: newbie
> Fix For: 3.0.4, 3.1.2, 3.3.0, 3.2.1
>
> Attachments: HDFS-14029.001.patch
>
>
> TestLazyPersistFiles#testFileShouldNotDiscardedIfNNRestarted test should be
> improved.
> The test sleeps for 6000 at once, it could at least sleep in a loop checking
> for the corrupt block to be reported.
> {code:java}
> cluster.shutdownDataNodes();
> cluster.restartNameNodes();
> // wait for the redundancy monitor to mark the file as corrupt.
> Thread.sleep(2 * DFS_NAMENODE_REDUNDANCY_INTERVAL_SECONDS_DEFAULT * 1000);
> Long corruptBlkCount = (long) Iterators.size(cluster.getNameNode()
> .getNamesystem().getBlockManager().getCorruptReplicaBlockIterator());
> {code}
> Thanks [~knanasi] for the suggestion.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
