[
https://issues.apache.org/jira/browse/HDDS-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664432#comment-16664432
]
Xiaoyu Yao commented on HDDS-103:
---------------------------------
Thanks [~ajayydv] for the update. Patch v4 looks good to me. Few minor comments:
SCMSecurityProtocolServer.java
Line 103: NIT: Should be "SCMSecurityProtocolServer"
Line 114: why do we need to explictly clean up scmNodeManager here?
StorageContainerManager.java
Line 806/845: we should set SecurityProtocolServer=null after it is stopped.
> SCM CA: Add new security protocol for SCM to expose security related functions
> ------------------------------------------------------------------------------
>
> Key: HDDS-103
> URL: https://issues.apache.org/jira/browse/HDDS-103
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDDS-103-HDDS-4.00.patch, HDDS-103-HDDS-4.01.patch,
> HDDS-103-HDDS-4.02.patch, HDDS-103-HDDS-4.03.patch, HDDS-103-HDDS-4.04.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
