[
https://issues.apache.org/jira/browse/HDDS-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664579#comment-16664579
]
Hudson commented on HDDS-682:
-----------------------------
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15325 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/15325/])
HDDS-682. Unified o3 address parsing for ozonen sh. Contributed by Elek,
(hanishakoneru: rev 38a65e3b7c2fe26cbc9aa4a514ddcfbb4639cd66)
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/ListBucketHandler.java
* (add)
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/web/ozShell/package-info.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/BucketCommands.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/volume/DeleteVolumeHandler.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/InfoKeyHandler.java
* (add)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/OzoneAddress.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/InfoBucketHandler.java
* (edit)
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/cli/GenericCli.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/ListKeyHandler.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/volume/CreateVolumeHandler.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/KeyCommands.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/volume/UpdateVolumeHandler.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/S3BucketMapping.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/UpdateBucketHandler.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/volume/InfoVolumeHandler.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/Handler.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/volume/ListVolumeHandler.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/PutKeyHandler.java
* (edit)
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/cli/GenericParentCommand.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/CreateBucketHandler.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/GetKeyHandler.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/keys/DeleteKeyHandler.java
* (edit)
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/ozShell/TestOzoneShell.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/DeleteBucketHandler.java
* (edit)
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/volume/VolumeCommands.java
* (add)
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/web/ozShell/TestOzoneAddress.java
> Unified o3 address parsing for ozonen sh
> ----------------------------------------
>
> Key: HDDS-682
> URL: https://issues.apache.org/jira/browse/HDDS-682
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Fix For: 0.4.0
>
> Attachments: HDDS-682.001.patch, HDDS-682.002.patch,
> HDDS-682.003.patch, HDDS-682.004.patch
>
>
> For ozone shell command (ozone sh) we have a common method to parse the o3
> url (org.apache.hadoop.ozone.web.ozShell.Handler.verifyURI) but there is no
> common method to parse the volume/bucket/key name from the uri.getPath().
> The error handling/parsing is different in each command handler. For example
> HDDS-315 fixed a problem with the info key, but we have exactly the same
> problem with many other endpoints (only the first segment of the key is used).
> As an example:
> {code}
> hadoop@476486ada939:~$ ozone sh key list /vol1/bucket
> [ ]
> hadoop@476486ada939:~$ ozone sh key put /vol1/bucket/dir1/file NOTICE.txt
> hadoop@476486ada939:~$ ozone sh key list /vol1/bucket
> [ {
> "version" : 0,
> "md5hash" : null,
> "createdOn" : "Wed, 17 Oct 2018 15:02:31 GMT",
> "modifiedOn" : "Wed, 17 Oct 2018 15:02:32 GMT",
> "size" : 22413,
> "keyName" : "dir1"
> } ]
> {code}
> Here the key name should be dir1/file instead of dir but the keyname is
> parsed in a wrong way. (same bug which is fixed by HDDS-315 for info key)
> I propose to create a common OzoneAddress class which can parse all the
> o3://, http:// type of urls, can create the OzoneClient, and provide the
> parser volume/bucket/key name.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
