[ 
https://issues.apache.org/jira/browse/HDFS-14029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664900#comment-16664900
 ] 

Adam Antal commented on HDFS-14029:
-----------------------------------

Thank you [~arpitagarwal] for the comment and the commit. 

I'd be grateful if you could commit to branch-2 as well. I provided a patch for 
it - the conflict was because EC is not present in branch-2, and the configs 
has changed.

> Sleep in TestLazyPersistFiles should be put into a loop
> -------------------------------------------------------
>
>                 Key: HDFS-14029
>                 URL: https://issues.apache.org/jira/browse/HDFS-14029
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs
>            Reporter: Adam Antal
>            Assignee: Adam Antal
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 3.0.4, 3.1.2, 3.3.0, 3.2.1
>
>         Attachments: HDFS-14029.001.patch, HDFS-14029.branch-2.001.patch
>
>
> TestLazyPersistFiles#testFileShouldNotDiscardedIfNNRestarted test should be 
> improved.
> The test sleeps for 6000 at once, it could at least sleep in a loop checking 
> for the corrupt block to be reported.
> {code:java}
>     cluster.shutdownDataNodes();
>     cluster.restartNameNodes();
>     // wait for the redundancy monitor to mark the file as corrupt.
>     Thread.sleep(2 * DFS_NAMENODE_REDUNDANCY_INTERVAL_SECONDS_DEFAULT * 1000);
>     Long corruptBlkCount = (long) Iterators.size(cluster.getNameNode()
>         .getNamesystem().getBlockManager().getCorruptReplicaBlockIterator());
> {code}
> Thanks [~knanasi] for the suggestion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to