[
https://issues.apache.org/jira/browse/HDFS-10554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Clampffer updated HDFS-10554:
-----------------------------------
Parent Issue: HDFS-14032 (was: HDFS-8707)
> libhdfs++: signed to unsigned conversions are breaking things and compiler
> isn't issuing expected warnings
> ----------------------------------------------------------------------------------------------------------
>
> Key: HDFS-10554
> URL: https://issues.apache.org/jira/browse/HDFS-10554
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: hdfs-client
> Reporter: James Clampffer
> Assignee: James Clampffer
> Priority: Major
>
> There's at least two places where we use -1 to indicate unset/default values
> that end up getting cast into unsigned integers. The compiler should be
> smart enough to figure this out and issue a warning but it's not; we need to
> find out what's going on there. We also need to fix the places where this
> sort of thing has found its way into the code:
> In URI
> {code}
> // -1 if the port is undefined.
> optional<uint16_t> get_port() const
> { return port; }
> {code}
> In Options (gets cast to uint64_t somewhere)
> {code}
> /**
> * Maximum number of retries for RPC operations
> **/
> int max_rpc_retries;
> static const int kNoRetry = -1;
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
