[
https://issues.apache.org/jira/browse/HDDS-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665705#comment-16665705
]
Ajay Kumar edited comment on HDDS-103 at 10/26/18 10:02 PM:
------------------------------------------------------------
[~xyao] thanks for review,
{quote}SCMSecurityProtocolServer.java
Line 103: NIT: Should be "SCMSecurityProtocolServer"
Line 114: why do we need to explictly clean up scmNodeManager here?{quote}
done
{quote}StorageContainerManager.java
Line 806/845: we should set SecurityProtocolServer=null after it is
stopped.{quote}
Since it is final we can't re-assign.
was (Author: ajayydv):
[~xyao] thanks for review,
{quote}SCMSecurityProtocolServer.java
Line 103: NIT: Should be "SCMSecurityProtocolServer"
Line 114: why do we need to explictly clean up scmNodeManager here?{quote}
{quote}StorageContainerManager.java
Line 806/845: we should set SecurityProtocolServer=null after it is
stopped.{quote}
Since it is final we can't re-assign.
> SCM CA: Add new security protocol for SCM to expose security related functions
> ------------------------------------------------------------------------------
>
> Key: HDDS-103
> URL: https://issues.apache.org/jira/browse/HDDS-103
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDDS-103-HDDS-4.00.patch, HDDS-103-HDDS-4.01.patch,
> HDDS-103-HDDS-4.02.patch, HDDS-103-HDDS-4.03.patch, HDDS-103-HDDS-4.04.patch,
> HDDS-103-HDDS-4.05.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
