[
https://issues.apache.org/jira/browse/HDDS-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662121#comment-16662121
]
Zsolt Horvath edited comment on HDDS-692 at 10/27/18 6:30 AM:
--------------------------------------------------------------
[~nandakumar131] thanks for helping me shaping this feature.
However, I'm not sure if I understand you wrt giving the actual task to the
{{Progressbar}} thread. The {{Progressbar}} class in-itself just a task
wrapper. In its {{public void start(Runnable task)}} the {{task}} parameter
used as a functional interface, it doesn't actually start a thread (so the task
will run in its original thread). It is the {{ProgressBarThread}} private inner
class, that starts a separate thread for drawing the progressbar.
As for the {{terminate}} method: in the {{RandomKeyGenerator}}'s case, N>1
threads/tasks get started by using an {{ExecutorService}}. What is the rule to
terminate the progressbar (if for example only 1 test job fails or just some)?
Sorry for my newbie questions, I'm just getting familiar with the code now.
was (Author: horzsolt2006):
[~nandakumar131] thanks for helping me shaping this feature.
However, I'm not sure if I understand you wrt giving the actual task to the
{{Progressbar}} thread. The {{Progressbar}} class in-itself just a task
wrapper. In its {{public void start(Runnable task)}} the task parameter used
for only as a wrapper, it doesn't actually start a thread, so the task will run
in its original thread. It is the {{ProgressBarThread}} private inner class,
that starts a thread for drawing the progressbar.
As for the {{terminate}} method: in the {{RandomKeyGenerator}}'s case N>1
threads/tasks get started by using an {{ExecutorService}}. What is the rule to
terminate the progressbar (1 fails, all fails)?
Sorry for my newbie questions, I'm just getting familiar with the code now.
> Use the ProgressBar class in the RandomKeyGenerator freon test
> --------------------------------------------------------------
>
> Key: HDDS-692
> URL: https://issues.apache.org/jira/browse/HDDS-692
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Zsolt Horvath
> Priority: Major
> Attachments: HDDS-692.001.patch
>
>
> HDDS-443 provides a reusable progress bar to make it easier to add more freon
> tests, but the existing RandomKeyGenerator test
> (hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java)
> still doesn't use it.
> It would be good to switch to use the new progress bar there.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
