[ https://issues.apache.org/jira/browse/HDFS-14033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667363#comment-16667363 ]
James Clampffer commented on HDFS-14033: ---------------------------------------- The patch looks good, it should just skip the libhdfs++ build if the platform can't support the thread_local specifier. I don't have an environment set up right now that doesn't support thread_local but I was able to set THREAD_LOCAL_SUPPORTED to false after the check this patch adds in the CMakeList.txt and verify that libhdfs++ stopped building. I tested and this works fine on platforms that do support thread_local. Version numbers for compiler support in the message would be nice e.g. "GCC >= 4.8" but not a blocker for getting the release out. +1. > [libhdfs++] Disable libhdfs++ build on systems that do not support > thread_local > ------------------------------------------------------------------------------- > > Key: HDFS-14033 > URL: https://issues.apache.org/jira/browse/HDFS-14033 > Project: Hadoop HDFS > Issue Type: Sub-task > Reporter: Anatoli Shein > Assignee: Anatoli Shein > Priority: Major > Attachments: HDFS-14033.000.patch > > > In order to still be able to build Hadoop on older systems (such as rhel 6) > we need to disable libhdfs++ build on systems that do not support > thread_local. We should also emit a warning saying libhdfs++ wasn't built. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org