[
https://issues.apache.org/jira/browse/HDDS-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668076#comment-16668076
]
Yiqun Lin commented on HDDS-759:
--------------------------------
+1 for the idea, [~arpitagarwal]. The patch almost looks good to me. Some minor
comments from me:
*ServerUtils#getScmDbDir*
{noformat}
LOG.warn("{} is not configured. We recommend adding this setting. " +
+ "Falling back to {} instead.",
+ HddsConfigKeys.OZONE_METADATA_DIRS, ScmConfigKeys.OZONE_SCM_DB_DIRS);
{noformat}
The parameters should be {{OZONE_SCM_DB_DIRS}} first, then
{{OZONE_METADATA_DIRS}}.
*The same problem in {{OmUtils#getOmDbDir}}*, you can take a look.
*OmUtils.java*
Logger instance get incorrectly in this class.
*Some common problems for UTs(TestHddsServerUtils and TestOmUtils )*:
* We should delete meta dir after each test.
* It would be better to add a corner case: no any meta dir (include om/scm
dir) is configured and to verify the thrown exception.
> Create config settings for SCM and OM DB directories
> ----------------------------------------------------
>
> Key: HDDS-759
> URL: https://issues.apache.org/jira/browse/HDDS-759
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Priority: Major
> Attachments: HDDS-759.01.patch
>
>
> Currently SCM, OM and DN all use {{ozone.metadata.dirs}} for storing
> metadata.
> Looking more closely, it appears that SCM and OM have no option to choose
> separate locations. We should provide custom config settings. For most
> production clusters, admins will want to carefully choose where they place OM
> and SCM metadata, similar to how they choose locations for NN metadata.
> To avoid disruption, we can have them fallback to {{ozone.metadata.dirs}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
