[
https://issues.apache.org/jira/browse/HDDS-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669699#comment-16669699
]
Yiqun Lin edited comment on HDDS-733 at 10/31/18 7:28 AM:
----------------------------------------------------------
[~ljain], the patch almost looks good to me. One suggestion for the UT: We can
send a additional {{ReadChunk}} request before {{WriteChunk}} request and
verify the StorageContainerException of CONTAINER_NOT_FOUND. So that, we have
verified that the container was created by {{WriteChunk}} request.
BTW, checkstyle issue can be fixed in the next patch, :).
was (Author: linyiqun):
[~ljain], the patch almost looks good to me. One suggestion for the UT: We can
send a additional {{ReadChunk}} request before {{WriteChunk}} request and
verify the SCMException of no container found. So that, we have verified that
the container was created by {{WriteChunk}} request.
BTW, checkstyle issue can be fixed in the next patch, :).
> Create container if not exist, as part of chunk write
> -----------------------------------------------------
>
> Key: HDDS-733
> URL: https://issues.apache.org/jira/browse/HDDS-733
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Datanode
> Reporter: Nanda kumar
> Assignee: Lokesh Jain
> Priority: Major
> Attachments: HDDS-733.001.patch
>
>
> The current implementation requires a container to be created in datanode
> before starting the chunk write. This can be optimized by creating the
> container on the first chunk write.
> During chunk write, if the container is missing, we can go ahead and create
> the container.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
